Address PR comments

penumbra-zone · Dec 23, 2024 · 96f45a2 · 96f45a2
1 parent c8e97b6
commit 96f45a2
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/packages/ui/src/Button/index.tsx b/packages/ui/src/Button/index.tsx
@@ -136,7 +136,7 @@ export const Button = forwardRef<HTMLButtonElement, ButtonProps>(
 
           'relative',
           'text-neutral-contrast',
-          'inline-flex items-center justify-center',
+          'flex items-center justify-center',
           density === 'sparse' ? 'gap-2' : 'gap-1',
         )}
       >

diff --git a/packages/ui/src/Text/index.tsx b/packages/ui/src/Text/index.tsx
@@ -19,6 +19,9 @@ import {
   tableHeading,
   tableHeadingMedium,
   tableHeadingSmall,
+  tableItem,
+  tableItemSmall,
+  tableItemMedium,
 } from '../utils/typography';
 import { ElementType, ReactNode } from 'react';
 import { ThemeColor } from '../utils/color';
@@ -141,6 +144,9 @@ const VARIANT_MAP: Record<TextVariant, { element: ElementType; classes: string }
   tableHeading: { element: 'span', classes: tableHeading },
   tableHeadingMedium: { element: 'span', classes: tableHeadingMedium },
   tableHeadingSmall: { element: 'span', classes: tableHeadingSmall },
+  tableItem: { element: 'span', classes: tableItem },
+  tableItemMedium: { element: 'span', classes: tableItemMedium },
+  tableItemSmall: { element: 'span', classes: tableItemSmall },
 };
 
 /**

diff --git a/packages/ui/src/Text/types.ts b/packages/ui/src/Text/types.ts
@@ -15,7 +15,10 @@ export type TextVariant =
   | 'body'
   | 'tableHeading'
   | 'tableHeadingMedium'
-  | 'tableHeadingSmall';
+  | 'tableHeadingSmall'
+  | 'tableItem'
+  | 'tableItemMedium'
+  | 'tableItemSmall';
 
 type TextType = {
   [K in TextVariant]: Record<K, true> & Partial<Record<Exclude<TextVariant, K>, never>>;

diff --git a/packages/ui/src/utils/typography.ts b/packages/ui/src/utils/typography.ts
@@ -61,4 +61,4 @@ export const button = cn('font-default text-textBase font-medium leading-textBas
 
 export const buttonMedium = cn('font-default text-textBase font-medium leading-textBase');
 
-export const buttonSmall = cn('font-default text-textXs font-medium leading-textBase');
+export const buttonSmall = cn('font-default text-textSm font-medium leading-textBase');
Original file line number	Diff line number	Diff line change
Expand Up		@@ -61,4 +61,4 @@ export const button = cn('font-default text-textBase font-medium leading-textBas

		export const buttonMedium = cn('font-default text-textBase font-medium leading-textBase');

		export const buttonSmall = cn('font-default text-textXs font-medium leading-textBase');
		export const buttonSmall = cn('font-default text-textSm font-medium leading-textBase');