Bump to tendermint 0.35 #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, will cut a release shortly |
cratelyn
pushed a commit
that referenced
this pull request
May 10, 2024
#47) this adds a `#[cfg(target_family = "unix")]` gate to the `listen_unix` method of `Server`. this fixes a broken build on non-unix systems. --- example: ``` ; git show --oneline --quiet HEAD 4b73065 (HEAD -> main, origin/main, origin/HEAD) tower-abci: use `[email protected]` (#46) ; cargo build --quiet --target x86_64-pc-windows-msvc && echo "build passed" error[E0432]: unresolved import `tokio::net::UnixListener` --> src/v038/server.rs:9:39 | 9 | net::{TcpListener, ToSocketAddrs, UnixListener}, | ^^^^^^^^^^^^ | | | no `UnixListener` in `net` | help: a similar name exists in the module: `TcpListener` | note: found an item that was configured out --> .cargo/registry/src/index.crates.io-6f17d22bba15001f/tokio-1.35.1/src/net/mod.rs:50:29 | 50 | pub use unix::listener::UnixListener; | ^^^^^^^^^^^^ For more information about this error, try `rustc --explain E0432`. error: could not compile `tower-abci` (lib) due to 1 previous error ; git switch unix-guard-v038 branch 'unix-guard-v038' set up to track 'heliaxdev/unix-guard-v038'. Switched to a new branch 'unix-guard-v038' ; git show --oneline --quiet HEAD 52382f4 (HEAD -> unix-guard-v038, heliaxdev/unix-guard-v038) add feature guard to unix-only listener in v038 ; cargo build --quiet --target x86_64-pc-windows-msvc && echo "build passed" build passed ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.