feat(pd): add app_version checks in local storage #4918
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
had a problem deploying
to
smoke-test
GitHub Actions
Failure
erwanor
reviewed
Nov 13, 2024
| /// Wrapper struct representing the `APP_VERSION`, intended | ||
| /// for custom TryInto/TryFrom implementations. | ||
| #[derive(Debug)] | ||
| struct AppVersion(u64); |
There was a problem hiding this comment.
If we write a proto to storage we can dispense with the wrapper type and custom serialization. In general, we should try to avoid doing custom serialization and using the _raw methods, preferring extension traits like StateWriteProto.
Here's an example of writing a primitive type to NV storage: https://github.com/penumbra-zone/penumbra/blob/main/crates/core/component/governance/src/component/view.rs#L978
erwanor
reviewed
Nov 13, 2024
| // use penumbra_app::app::StateReadExt as _; | ||
| use penumbra_app::APP_VERSION; | ||
|
|
||
| const APP_VERSION_KEY: &str = "app_version"; |
There was a problem hiding this comment.
Can we move this with the other application state keys
|
closing in favor of #4919 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Initial spike on adding support for
APP_VERSIONtopd startandpd migrate. Opening early to facilitate discussion and collaboration.Issue ticket number and link
Towards #4793.
Checklist before requesting a review
I have added guiding text to explain how a reviewer should test these changes.
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: