-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linear liquidity strategies in pcli #4800
Conversation
There are rendering issues when using this with USDC, because there's no entry in the asset registry, so it shows a rounded price for upenumbra in terms of uusdc:
This should be fixed by allowing pcli to load a registry from its home directory rather than rearranging the rendering code |
e111776
to
09f52a1
Compare
Rebased on top of #4801 |
09f52a1
to
12191b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested the different options with an actual registry. There are some rough edges we can sand off in subsequent PRs related to parsing using the asset registry, to avoid needing to know internal asset identification as thoroughly.
Tracked in #4803. |
Closes #4112
Describe your changes
Description TK
This strategy is the line labeled "demo", and it's simpler to implement than UniV3 but with a similarly shaped PVF
Issue ticket number and link
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: