Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pcli tx lp close/withdraw to accept multiple position IDs #4490

Merged

Conversation

kerber0x
Copy link
Contributor

Describe your changes

This PR makes the pcli tx lp close/withdraw to take multiple position IDs.

Issue ticket number and link

Closes #4217

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    REPLACE THIS TEXT WITH RATIONALE (CAN BE BRIEF)

@kerber0x kerber0x changed the title Improvement/pcli multiple tx params refactor: pcli tx lp close/withdraw to accept multiple position IDs May 28, 2024
@kerber0x kerber0x force-pushed the improvement/pcli-multiple-tx-params branch from 5ad778f to b64e91c Compare May 28, 2024 16:15
@kerber0x kerber0x force-pushed the improvement/pcli-multiple-tx-params branch from b64e91c to 7ef715e Compare May 28, 2024 16:26
@kerber0x kerber0x marked this pull request as ready for review May 28, 2024 17:01
@erwanor erwanor self-requested a review May 30, 2024 11:38
Copy link
Member

@erwanor erwanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, thank you

@erwanor erwanor merged commit 58b389b into penumbra-zone:main May 30, 2024
13 checks passed
@erwanor erwanor added A-client Area: Design and implementation for client functionality A-dex Area: Relates to the dex labels May 30, 2024
@erwanor erwanor added this to the Sprint 7 milestone May 30, 2024
@kerber0x kerber0x deleted the improvement/pcli-multiple-tx-params branch June 3, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: Design and implementation for client functionality A-dex Area: Relates to the dex
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Make pcli tx lp close/withdraw take multiple position IDs
2 participants