Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex: add duration metric for SimulateTrade RPC (#4454) #4466

Merged
merged 1 commit into from
May 24, 2024

Conversation

conorsch
Copy link
Contributor

Describe your changes

Backports #4454 for inclusion in v0.76.0. Refs #4402. Closes #4457. (cherry picked from commit e1d8b2c)

Issue ticket number and link

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    metrics emission, no changes to consensus logic

Backports #4454 for inclusion in v0.76.0. Refs #4402. Closes #4457.
(cherry picked from commit e1d8b2c)
@conorsch conorsch requested a review from cratelyn May 24, 2024 17:15
@cratelyn cratelyn added A-telemetry Area: Metrics, logging, and other observability-related features A-dex Area: Relates to the dex labels May 24, 2024
@cratelyn cratelyn added this to the Sprint 7 milestone May 24, 2024
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍒 🎉

@conorsch conorsch merged commit 75e39bc into main May 24, 2024
13 checks passed
@conorsch conorsch deleted the 4457-swap-metrics branch May 24, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dex Area: Relates to the dex A-telemetry Area: Metrics, logging, and other observability-related features
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add histogram metrics for end-to-end CheckTx latency
3 participants