backport: pd: refuse to bootstrap services if the app is not ready (#4436) #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the halting logic was structured such that full nodes would partially crash two of their four ABCI services (`Consensus` and `Mempool`); relying on future CometBFT consensus requests to crash the node. This PR adds an `App::is_ready` method that callers (pd) SHOULD call in order to make sure that the application is ready, so that they can avoid to spin up any services unless an override flag (`--force`) is specified. Fix #4432. Fix #4443. - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > Full node mechanical refactor (cherry picked from commit 2c9c3f3)
conorsch
force-pushed
the
pd-halt-fix-for-0.75.x
branch
from
51e8d20 to
4f33f1a
Compare
erwanor
approved these changes
May 23, 2024
|
There's a single CI failure on this PR, the docs-lint job is failing: https://github.com/penumbra-zone/penumbra/actions/runs/9213808726/job/25348533450?pr=4450 That's because we didn't backport the CI fix in #4415 to this release branch. I'm not going to bother doing that, because docs are built from main anyway, and I want to get this out the door as 0.75.1. Proceeding with merge. |
conorsch
changed the title
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Backports changes from #4436, towards #4448.
Checklist before requesting a review