-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auction: credit VCB when ending an auction #4394
Conversation
a0b21ed
to
24210b4
Compare
I have tested this in two ways:
Additionally, I ran the migration on a fork of the running testnet to observe if any deviations were recorded, but without resuming. I didn't see any deviations, that is to say the tallied auction VCB and the one onchain were equal. |
This is generating conflicts to every other U1 migrations and has received a lot of offline attention so merging this optimistically, but async reviews are welcome. |
Describe your changes
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: