ibc: audit fixes #4386
Merged
ibc: audit fixes #4386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avahowell
added
security
erwanor
reviewed
May 21, 2024
| @@ -142,6 +142,14 @@ pub trait ClientUpgradeProofVerifier: StateReadExt { | |||
| .get_verified_consensus_state(&trusted_client_state.latest_height(), client_id) | |||
| .await?; | |||
|
|
|||
| // check that the client is not expired | |||
| let now = HI::get_block_timestamp(&self).await?; | |||
There was a problem hiding this comment.
nice, something to flag is that i noticed the other host chain interface methods are not used (or rust-analyzer can't seem to find them)
cronokirby
reviewed
May 21, 2024
crates/core/component/ibc/src/component/msg_handler/connection_open_ack.rs
Show resolved
Hide resolved
cronokirby
approved these changes
May 21, 2024
erwanor
added
the
zellic-ibc-remediated
|
We believe that this PR may resolve a lingering blocker for interchaintest, where timeouts were not being handled properly. Let's include this for Testnet 76 (#4402), so downstream can consume it, and press on with the testing integration. Before I mash the merge button, @avahowell could you respond to @cronokirby's comments above? It'd be helpful to have the narrative when we refer back to this changeset. |
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR contains a set of fixes for the higher sev issues from the recent audit of the penumbra-ibc codebase, that are specific to the state machine side of things (as opposed to
ibc-types, there will be a follow up PR for ibc-types and a new release for the relevant fixes there).Checklist before requesting a review
closes #4421
closes #4420
closes #4419
closes #4418