-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
penumbra: use core.auction.v1
#4368
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
added
A-node
Area: System design and implementation for node software
consensus-breaking
breaking change to execution of on-chain data
protobuf-breaking-changes
Makes breaking changes to the protobuf definitions.
state-breaking
breaking change to on-chain data
A-auction
Area: Relates to the auction component
labels
May 9, 2024
27 tasks
conorsch
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The buf-lint job is failing, which is expected: we're moving proto versions. But the change is narrowly scoped to affect only the auction interfaces, which is what we want. Other CI jobs must pass, though.
1 task
Confirmed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-auction
Area: Relates to the auction component
A-node
Area: System design and implementation for node software
consensus-breaking
breaking change to execution of on-chain data
protobuf-breaking-changes
Makes breaking changes to the protobuf definitions.
state-breaking
breaking change to on-chain data
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This tags a
v1
protobuf package for the auction component.It includes a breaking changes to
penumbra.v1
since we use the newv1
package to directly replace the previous references to the auction component in the app, view, transaction, and governance components. This is an exceptional deviation from process because this project was in active development with a single consumer.Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: