fees: add unit tests #4316
Closed
fees: add unit tests #4316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
added
A-testing
erwanor
requested changes
May 6, 2024
| let fee = planner.fee_estimate(&planner.gas_prices, &planner.fee_tier); | ||
| planner.adjust_change_for_fee(fee); | ||
|
|
||
| if planner.balance().is_zero() { |
There was a problem hiding this comment.
Isn't this cheating? The plan should balance once we run out of required notes if we have correctly refreshed the change notes
| planner.actions = planner.plan.actions.clone(); | ||
|
|
||
| let mut iterations = 0usize; | ||
| while let Some(_required) = planner |
There was a problem hiding this comment.
I think adding tests is a great idea, but my sense is that rather than replicating the logic (which has changed since this PR was opened) we should either:
- refactor the core planning logic into a pure function
- check in on Design a way to use the Rust view server with mock consensus integration tests #3913 to see if the plan is to be able to build a mock view client at some point, in which case we can use
Planner::plandirectly
There was a problem hiding this comment.
My intuition is that it's probably best to wait a little longer until we try to test this, we'll definitely have less turbulence in the planner in a couple weeks time or less
|
cc @cratelyn closing out since it's fallen out of sync with the latest round of refactors. This can be a reference for eventually integrating into the mock consensus suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
I modified the unit tests for fees according to the updated planner logic.
Issue ticket number and link
Checklist before requesting a review
References #4155