Add stateful checks for chain ID and expiry height

[plaidfinch]

Describe your changes

Resolves #4308.

Checklist before requesting a review

• If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

This is a consensus-breaking change.

[plaidfinch]

Looks like there are tests which are not setting the chain ID. Is this because the chain ID is set correctly in client tooling but not in tests, or is it not set in both?

[erwanor]

Thanks a lot for noticing this, and taking the time to make a PR to fix it, I am very appreciative that this was caught. ACK, I'm going to push this across the finish line by fixing the test suite and destructuring TransactionParameters so that something breaks loudly if an addition is made.

[plaidfinch]

Should this be merged now? Happy to push the button myself but wanted to double-check since it contains consensus-breaking changes.

[hdevalence]

Just for clarification: was this necessary to make the change? It seems desirable to allow the chain ID to be "" for testing, and it seems like there's no downside since any real network will have a chain ID (which wherefore won't match).

[erwanor]

It's not necessary, and an empty chain id would work!

[hdevalence]

Let's wait to merge this until after resolving our current planner issues.

[erwanor]

I'm going to rebase against main and merge on green ci.