Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fee: unit tests #4305

Closed
wants to merge 1 commit into from
Closed

fee: unit tests #4305

wants to merge 1 commit into from

Conversation

TalDerei
Copy link
Collaborator

@TalDerei TalDerei commented May 2, 2024

Describe your changes

Unit tests for fees

Issue ticket number and link

References #4155

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

@TalDerei TalDerei self-assigned this May 2, 2024
@TalDerei TalDerei requested a review from erwanor May 2, 2024 20:11
@TalDerei TalDerei marked this pull request as ready for review May 3, 2024 16:59
@erwanor
Copy link
Member

erwanor commented May 3, 2024

WDYT about revisiting this once we have closed the loop on the planner work (including voting, and canonical ordering)

@TalDerei
Copy link
Collaborator Author

TalDerei commented May 3, 2024

WDYT about revisiting this once we have closed the loop on the planner work (including voting, and canonical ordering)

yes agreed!

@erwanor
Copy link
Member

erwanor commented May 3, 2024

I'll close for now so that we have an accurate view of what's on-going vs not

@erwanor erwanor closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants