-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
view: port wasm planner to core #4300
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
reviewed
May 1, 2024
TalDerei
commented
May 2, 2024
TalDerei
commented
May 2, 2024
Co-Authored-By: Tal Derei <[email protected]>
Co-Authored-By: Tal Derei <[email protected]>
Co-Authored-By: Tal Derei <[email protected]>
Co-Authored-By: Tal Derei <[email protected]>
erwanor
added
the
A-client
Area: Design and implementation for client functionality
label
May 3, 2024
I reviewed the surplus logic again, and checks out to me. Merge on your approval ~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds a port of the wasm planner, integrating it within the
penumbra-view
crate.SwapClaim
handlingIn the process of porting this PR, we found a bug in the handling of
SwapClaim
actions with the wasm planner.SwapClaim
actions produce surplus value from their prepaid fees) that must be released so that the transaction balance to zero. In principle, it should be possible to release this value into an output note. This isn't the approach we took with this PR. Instead, we release it to the transaction fee, providing a base for us to improve on later.Voting regression
The original WASM planner did not handle delegator/validator voting. This PR does not yet attempt to do so either. The pcli integration test for delegator voting is commented out.
Issue ticket number and link
References #4081
Checklist before requesting a review