auction: add views to the ActionView definition
#4295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
force-pushed
the
erwan/txp_txv_da_impls
branch
from
6d9295f to
2a81ac8
Compare
erwanor
commented
May 1, 2024
| component.auction.v1alpha1.ActionDutchAuctionEnd action_dutch_auction_end = 54; | ||
| component.auction.v1alpha1.ActionDutchAuctionWithdraw action_dutch_auction_withdraw = 55; | ||
| component.auction.v1alpha1.ActionDutchAuctionWithdrawView action_dutch_auction_withdraw = 55; |
There was a problem hiding this comment.
@jessepinho oversight on our end, but this should fix it.
erwanor
added
protobuf-breaking-changes
erwanor
changed the title
ActionViewsActionView definition
|
Does this break protos that were released, or just what's on main? |
conorsch
approved these changes
May 1, 2024
|
we publish to the BSR on main right? the blast damage should only be a branch in the web repo though |
|
checking my understanding: this is not a |
cratelyn
approved these changes
May 1, 2024
|
@cratelyn that's right, however this would be a pretty bad client breaking change |
|
Let's break some protos, shall we 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds
ActionDutchAuctionScheduleViewandActionDutchAuctionWithdrawViewto theActionViewmessage, it also replaces theIsActionperspective impls with concrete implementation.Populating a view for the withdraw action without extending the
TxPstructure has proven squirrelly, and it will require a follow-up, although the data is "here" in the view server so I don't think it will be too complicated.Issue ticket number and link
Part of #4219
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: