dex: Extend arbitrage routing #4292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbuc
force-pushed
the
4177_extended_candidate_Set
branch
from
587bc40 to
b949ec0
Compare
hdevalence
reviewed
Apr 30, 2024
| .cloned() | ||
| // Limit the inclusion of recently accessed assets to 10 to avoid | ||
| // potentially blowing up routing time. | ||
| .chain(state.recently_accessed_assets().iter().take(10).cloned()) |
There was a problem hiding this comment.
This could have duplicates right? should we accumulate into a BTreeSet instead until its size increases by the max limit?
There was a problem hiding this comment.
The recently_accessed_assets set is also incredibly likely to feature assets that are already in the fixed list, perhaps they should be filtered out on insertion as well.
…nd recently swapped assets
… size enforcement to the setter
zbuc
force-pushed
the
4177_extended_candidate_Set
branch
from
78b7e3c to
c6449fa
Compare
zbuc
force-pushed
the
4177_extended_candidate_Set
branch
from
c6449fa to
1425f61
Compare
zbuc
force-pushed
the
4177_extended_candidate_Set
branch
from
1425f61 to
fcdb1e5
Compare
aubrika
added
the
friction
cratelyn
removed
the
friction
erwanor
approved these changes
May 7, 2024
| ); | ||
| self.add_recently_accessed_asset( | ||
| position.phi.pair.asset_2(), | ||
| routing_params.fixed_candidates, |
There was a problem hiding this comment.
It was a minor surprise that this wasn't internalized by add_recently_accessed_asset but I guess we technically save a lookup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR extends arbitrage routing to route against assets involved in swaps and positions opened during the current block.
Issue ticket number and link
#4177
Checklist before requesting a review