auction: connect auction component to application #4259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
added
protobuf-changes
erwanor
added
the
consensus-breaking
erwanor
added a commit
that referenced
this pull request
Apr 24, 2024
## Describe your changes This PR adds: - auction genesis content to the application state - auction parameters to the application state (and governance update logic) - connects the app ABCI implementation to the auction's component interface ## Issue ticket number and link #4228 and #4252 ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > This is consensus breaking
erwanor
added a commit
that referenced
this pull request
Apr 24, 2024
This PR adds: - auction genesis content to the application state - auction parameters to the application state (and governance update logic) - connects the app ABCI implementation to the auction's component interface - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > This is consensus breaking
erwanor
added a commit
that referenced
this pull request
Apr 24, 2024
This PR adds: - auction genesis content to the application state - auction parameters to the application state (and governance update logic) - connects the app ABCI implementation to the auction's component interface - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > This is consensus breaking
|
This was state-breaking because the auction component adds its own set of parameters to the app state! |
1 task
hdevalence
pushed a commit
that referenced
this pull request
May 7, 2024
…4338) ## Describe your changes @hdevalence noticed that we were missing a migration for the `AuctionParameters`. This PR adds a migration to write the parameters to the app state. ## Issue ticket number and link This was a miss in #4259 ## Checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > This is a migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds:
Issue ticket number and link
#4228 and #4252
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: