Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pd): add --gas-price-simple flag to generate #4258

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

conorsch
Copy link
Contributor

@conorsch conorsch commented Apr 22, 2024

Describe your changes

Adds a new CLI flag for pd testnet generate, to opt in to non-zero gas
prices. It's a bit of a shortcut to reuse the same numeric value across
all of them, but we can always add more CLI flags later to finetune.

Closes #4154.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    Adds opt-in behavior, and modifies CI runs, but does not touch application code.

Testing/review

The simplest way to validate the new behavior here is:

  1. check out this feature branch
  2. cargo run --bin pd -- testnet generate --gas-price-simple 5
  3. start cometbft/pd to serve the local devnet
  4. configure pcli to use http://locahost:8080 as grpc_addr
  5. run pcli --home <path> view balance and confirm you have multiple denoms
  6. run pcli --home <path> tx send --to <different_addr_in_same_wallet> 1test_usd
  7. run pcli --home <path> view balance and confirm that 1) the sent denom moved; and 2) a wee bit of penumbra was burned to pay the fee.

Adds a new CLI flag for `pd testnet generate`, to opt in to non-zero gas
prices. It's a bit of a shortcut to reuse the same numeric value across
all of them, but we can always add more CLI flags later to finetune.

Closes #4154.
@conorsch conorsch force-pushed the 4154-gas-prices-in-pd-generate branch from 2c29d23 to d432eac Compare April 22, 2024 23:55
@conorsch conorsch requested a review from TalDerei April 22, 2024 23:56
@conorsch conorsch marked this pull request as ready for review April 22, 2024 23:58
@TalDerei
Copy link
Collaborator

LGTM!

so the trick here is to use another denom? I'm looking forward to seeing how our modified planner logic fares in this smoke test environment.

@conorsch
Copy link
Contributor Author

so the trick here is to use another denom? I'm looking forward to seeing how our modified planner logic fares in this smoke test environment.

To my surprise, I didn't need to modify the smoke tests at all, because the tx send tests already use a non-staking token TEST_ASSET, so the addition of fees doesn't affect the balance checks of TEST_ASSET.

@conorsch conorsch merged commit d23a09a into main Apr 23, 2024
8 checks passed
@conorsch conorsch deleted the 4154-gas-prices-in-pd-generate branch April 23, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

add a flag to testnet-generate to start a testnet with non-zero gas prices
2 participants