feat(pd): add --gas-price-simple flag to generate #4258
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a new CLI flag for
pd testnet generate
, to opt in to non-zero gasprices. It's a bit of a shortcut to reuse the same numeric value across
all of them, but we can always add more CLI flags later to finetune.
Closes #4154.
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:
Testing/review
The simplest way to validate the new behavior here is:
cargo run --bin pd -- testnet generate --gas-price-simple 5
pcli --home <path> view balance
and confirm you have multiple denomspcli --home <path> tx send --to <different_addr_in_same_wallet> 1test_usd
pcli --home <path> view balance
and confirm that 1) the sent denom moved; and 2) a wee bit of penumbra was burned to pay the fee.