auction: process triggers/execute DAs

crates/core/component/auction/src/auction/dutch.rs

@@ -1,3 +1,5 @@
+use std::num::NonZeroU64;
+
 use anyhow::anyhow;
 use penumbra_asset::{asset, Value};
 use penumbra_dex::lp::position::{self};
@@ -168,7 +170,7 @@ impl TryFrom<pb::DutchAuctionDescription> for DutchAuctionDescription {
 pub struct DutchAuctionState {
     pub sequence: u64,
     pub current_position: Option<position::Id>,
-    pub next_trigger: u64,
+    pub next_trigger: Option<NonZeroU64>,
     pub input_reserves: Amount,
     pub output_reserves: Amount,
 }
@@ -183,7 +185,7 @@ impl From<DutchAuctionState> for pb::DutchAuctionState {
         Self {
             seq: domain.sequence,
             current_position: domain.current_position.map(Into::into),
-            next_trigger: domain.next_trigger,
+            next_trigger: domain.next_trigger.map_or(0u64, Into::into),
             input_reserves: Some(domain.input_reserves.into()),
             output_reserves: Some(domain.output_reserves.into()),
         }
@@ -197,7 +199,7 @@ impl TryFrom<pb::DutchAuctionState> for DutchAuctionState {
         Ok(DutchAuctionState {
             sequence: msg.seq,
             current_position: msg.current_position.map(TryInto::try_into).transpose()?,
-            next_trigger: msg.next_trigger,
+            next_trigger: NonZeroU64::new(msg.next_trigger),
             input_reserves: msg
                 .input_reserves
                 .ok_or_else(|| anyhow!("DutchAuctionState message is missing input reserves"))?

crates/core/component/auction/src/auction/dutch/actions/schedule.rs

@@ -5,6 +5,10 @@ use penumbra_proto::{core::component::auction::v1alpha1 as pb, DomainType};
 use penumbra_txhash::{EffectHash, EffectingData};
 use serde::{Deserialize, Serialize};
 
+/// The maximum amount of input/output in a Dutch auction description.
+/// 52 bits gives us enough headroom to do infaillible price interpolation.
+pub const MAX_AUCTION_AMOUNT_RESERVES: u128 = (1 << 52) - 1;
+
 #[derive(Debug, Clone, Serialize, Deserialize)]
 #[serde(
     try_from = "pb::ActionDutchAuctionSchedule",

crates/core/component/auction/src/component/action_handler/dutch/schedule.rs

@@ -1,9 +1,11 @@
+use crate::auction::dutch::actions::schedule::MAX_AUCTION_AMOUNT_RESERVES;
 use crate::auction::dutch::DutchAuctionDescription;
 use crate::component::AuctionStoreRead;
 use anyhow::{ensure, Result};
 use async_trait::async_trait;
 use cnidarium::StateWrite;
 use cnidarium_component::ActionHandler;
+use penumbra_num::Amount;
 use penumbra_sct::component::clock::EpochRead;
 
 use crate::auction::dutch::ActionDutchAuctionSchedule;
@@ -24,9 +26,21 @@ impl ActionHandler for ActionDutchAuctionSchedule {
             nonce: _,
         } = self.description;
 
-        // Fail fast if the step count is zero
+        // Fail fast if the input is zero.
+        ensure!(
+            input.amount > Amount::zero(),
+            "input amount MUST be positive (got zero)"
+        );
+
+        // Fail fast if the step count is zero.
         ensure!(step_count > 0, "step count MUST be positive (got zero)");
 
+        // Check that the input amount is less than 52 bits wide.
+        ensure!(
+            input.amount <= MAX_AUCTION_AMOUNT_RESERVES.into(),
+            "input amount MUST be less than 52 bits wide"
+        );
+
         // Check that we disallow identical input/output ids.
         ensure!(
             input.asset_id != output_id,
@@ -42,6 +56,21 @@ impl ActionHandler for ActionDutchAuctionSchedule {
         // Check that the max output is greater than zero.
         ensure!(max_output > 0u128.into(), "max output MUST be positive");
 
+        // Check that the max output is less than 52 bits wide.
+        ensure!(
+            max_output <= MAX_AUCTION_AMOUNT_RESERVES.into(),
+            "max output amount MUST be less than 52 bits wide"
+        );
+
+        // Check that the min output is greater than zero.
+        ensure!(min_output > 0u128.into(), "min output MUST be positive");
+
+        // Check that the min output is less than 52 bits wide.
+        ensure!(
+            min_output <= MAX_AUCTION_AMOUNT_RESERVES.into(),
+            "min output amount MUST be less than 52 bits wide"
+        );
+
         // Check that the start and end height are valid.
         ensure!(
             start_height < end_height,
@@ -50,16 +79,17 @@ impl ActionHandler for ActionDutchAuctionSchedule {
             end_height
         );
 
-        // Check that the step count is positive.
+        // Check that the step count is at least 2. This is important
+        // because DA price interpolation assumes that `step_count-1` is positive.
         ensure!(
-            step_count > 0,
-            "step count MUST be greater than zero (got: {step_count})"
+            step_count >= 2,
+            "step count MUST be at least two (got: {step_count})"
         );
 
-        // Check that the step count is less than 1000.
+        // Check that the step count is less than 255.
         ensure!(
-            step_count <= 1000,
-            "the dutch auction step count MUST be less than 1000 (got: {step_count})",
+            step_count <= 255,
+            "the dutch auction step count MUST be less than 255 (got: {step_count})",
         );
 
         // Check that height delta is a multiple of `step_count`.

crates/core/component/auction/src/component/auction.rs

@@ -1,3 +1,4 @@
+use crate::component::dutch_auction::HandleDutchTriggers;
 use anyhow::Result;
 use async_trait::async_trait;
 use cnidarium::{StateRead, StateWrite};
@@ -27,11 +28,13 @@ impl Component for Auction {
     ) {
     }
 
-    #[instrument(name = "auction", skip(_state, _end_block))]
+    #[instrument(name = "auction", skip(state, end_block))]
     async fn end_block<S: StateWrite + 'static>(
-        _state: &mut Arc<S>,
-        _end_block: &abci::request::EndBlock,
+        state: &mut Arc<S>,
+        end_block: &abci::request::EndBlock,
     ) {
+        let state: &mut S = Arc::get_mut(state).expect("state should be unique");
+        let _ = state.process_triggers(end_block.height as u64).await;
     }
 
     #[instrument(name = "auction", skip(_state))]