Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auction: pd service rpc #4233

Merged
merged 11 commits into from
Apr 19, 2024
Merged

auction: pd service rpc #4233

merged 11 commits into from
Apr 19, 2024

Conversation

TalDerei
Copy link
Collaborator

@TalDerei TalDerei commented Apr 17, 2024 •
edited
Loading

Describe your changes

Define minimal auction pd rpc service in the protos.

Issue ticket number and link

References #4226

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

@TalDerei TalDerei self-assigned this Apr 17, 2024
@TalDerei TalDerei changed the title Auction service rpc auction: pd service rpc Apr 17, 2024
@TalDerei TalDerei marked this pull request as ready for review April 18, 2024 13:14
@TalDerei TalDerei requested a review from erwanor April 18, 2024 13:14
@erwanor erwanor added protobuf-changes Makes changes to the protobuf definitions. A-auction Area: Relates to the auction component labels Apr 19, 2024
erwanor
erwanor approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@erwanor erwanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge on green CI, the change to use the pbjson_types override seems fine, as far as I can tell it "just" consumes the prost-types WKTs and augments it with ser/des. We can revisit later anyway, good work ship it

@cratelyn cratelyn added this to the Sprint 4 milestone Apr 19, 2024
@TalDerei TalDerei merged commit 16f904e into main Apr 19, 2024
8 checks passed
@TalDerei TalDerei deleted the auction-service-rpc branch April 19, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwanor erwanor erwanor approved these changes

Assignees

@TalDerei TalDerei

Labels
A-auction Area: Relates to the auction component protobuf-changes Makes changes to the protobuf definitions.
Projects
Penumbra
Status: Done
Milestone
Sprint 4
Development

Successfully merging this pull request may close these issues.
3 participants
@TalDerei @erwanor @cratelyn