Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex(base_liq): add async_trait to BaseLiquidityIndex #4224

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Apr 16, 2024

Describe your changes

This slipped when doing #4188. I'm not completely sure yet why CI didn't catch this.

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    Internal

@erwanor erwanor added C-bug Category: a bug A-dex Area: Relates to the dex labels Apr 16, 2024
@erwanor erwanor added this to the Sprint 4 milestone Apr 16, 2024
@erwanor erwanor self-assigned this Apr 16, 2024
@erwanor erwanor force-pushed the erwan/fix_async_trait branch from 3a42e32 to 7707414 Compare April 16, 2024 20:26
@erwanor erwanor force-pushed the erwan/fix_async_trait branch from 7707414 to b4f3529 Compare April 16, 2024 20:26
Copy link
Contributor

@aubrika aubrika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aubrika aubrika merged commit af94d43 into main Apr 16, 2024
8 checks passed
@aubrika aubrika deleted the erwan/fix_async_trait branch April 16, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-dex Area: Relates to the dex C-bug Category: a bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants