feat(governance): 🧊 test that community pool spend proposals can be disabled

[cratelyn]

fixes #4079. related to, but does not finish #2105.

this introduces a new governance parameter that can be used to freeze or unfreeze the community pool. this branch additionally introduces a few mock consensus tests to exercise the governance component, to show that it works when unfrozen, and is properly disabled when frozen.

this introduces test coverage to show that community pool spend proposals can be disabled via a chain parameter.

"the point"

the core mechanical change of this branch is made in these commits: see #4222 (comment) below.

• f88a981 feat(app): ✅ no spend proposals when pool is frozen
• 5129012 feat(app): 🧊 community pool actions not accepted when frozen
• 51e7063 feat(proto): 🏂 add community_pool_is_frozen to governance params

NB: this is a consensus-breaking change, as a parameter will now block community pool transactions when this new parameter is active.

related changes

some changes made, related to writing tests for the governance component:

• 6b3be58 refactor(governance): 💶 Value accessors for proposal actions
• de16dac feat(tx): 🌮 ActionPlan: From for community pool actions
• 4e6b874 feat(amount): ➖ Amount: std::ops::SubAssign

tests

this addresses part of #2105. we should add tests that exercise the other
tallying logic before that issue is complete. tests are added in the following
commits:

• fedfa8d tests(app): 💭 test a community pool spend
• 201fe48 tests(app): 🏊 test a community pool deposit
• 8543869 tests(app): 🥶 test that community pool can be frozen

[cratelyn]

💬 a tertiary discussion point

i see the following parameter: https://github.com/penumbra-zone/penumbra/blob/main/crates/core/component/community-pool/src/params.rs#L10-L13

my understanding is that this is similar, but not completely the same as, community_pool_is_frozen. i'd like to briefly gesture at it though, in case this sounds incorrect.

[hdevalence]

💬 a tertiary discussion point

i see the following parameter: https://github.com/penumbra-zone/penumbra/blob/main/crates/core/component/community-pool/src/params.rs#L10-L13

my understanding is that this is similar, but not completely the same as, community_pool_is_frozen. i'd like to briefly gesture at it though, in case this sounds incorrect.

Hmm, it looks pretty much the same to me

[hdevalence]

maybe we don't need both?

[cratelyn]

💬 a tertiary discussion point

i see the following parameter: https://github.com/penumbra-zone/penumbra/blob/main/crates/core/component/community-pool/src/params.rs#L10-L13
my understanding is that this is similar, but not completely the same as, community_pool_is_frozen. i'd like to briefly gesture at it though, in case this sounds incorrect.

Hmm, it looks pretty much the same to me

cool, i am glad i asked! to state the difference explicitly, this new parameter also prevents community pool deposits when the pool is frozen. whether that is a useful property, i'm unsure.

we probably don't need both though, i think that is a fair point nonetheless. in that case @hdevalence, do you think that we should keep the existing option, or remove/deprecate it in favor of this option?

[hdevalence]

I think we should just have one parameter, it was an oversight on my part to not check that the work was already completed. The important thing is making sure that there's a chain parameter that prevents any community pool transactions from occurring.

[cratelyn]

I think we should just have one parameter, it was an oversight on my part to not check that the work was already completed. The important thing is making sure that there's a chain parameter that prevents any community pool transactions from occurring.

sounds good. i'll suggest the following course:

• 1. revert the commits here introducing a new parameter.
• 2. rephrase the tests to work with the existing parameter.

at risk of being pedantic again, the existing community_pool_spend_proposals_enabled parameter only blocks specifically the proposal of community pool spend proposals, and transactions depositing into the pool are still allowed when that flag is on. that is, community_pool_spend_proposals_enabled lets funds go into the pool, but not out.

i think that is fine, but i want to be sure that it serves our needs, re: "prevents any community pool transactions from occurring." if so, this pr doesn't need to be consensus-breaking, and we can just treat this as the addition of more tests.