Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auction: define main dutch auction messages #4208

Merged
merged 9 commits into from
Apr 15, 2024

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Apr 15, 2024

Describe your changes

This PR adds the main domain types and protobuf definitions for dutch auction support.

Issue ticket number and link

Part of #4206

Checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    Component is not hooked to the app yet and this just adds messages/types.

@erwanor erwanor added protobuf-changes Makes changes to the protobuf definitions. A-auction Area: Relates to the auction component labels Apr 15, 2024
@erwanor erwanor added this to the Sprint 4 milestone Apr 15, 2024
@erwanor erwanor self-assigned this Apr 15, 2024
Co-authored-by: katelyn martin <[email protected]>
Signed-off-by: Erwan Or <[email protected]>
Copy link
Contributor

@cratelyn cratelyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow on to previous suggestion

crates/core/component/auction/src/auction/dutch.rs Outdated Show resolved Hide resolved
@erwanor erwanor merged commit 2aa7094 into main Apr 15, 2024
8 checks passed
@erwanor erwanor deleted the erwan/4206_dutch_auction_msgs branch April 15, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-auction Area: Relates to the auction component protobuf-changes Makes changes to the protobuf definitions.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants