Add an AssetMetadataByIds method to the shielded pool query RPC #4201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepinho
force-pushed
the
jessepinho/asset-metadata-by-ids-4162
branch
from
7371b92 to
50ba021
Compare
jessepinho
changed the title
|
Sorry @jessepinho this slipped through the cracks, I'll review, rebase conflicts, and approve before EOW (unless someone beat me to it :) ) |
erwanor
force-pushed
the
jessepinho/asset-metadata-by-ids-4162
branch
from
c555b13 to
ac21f9c
Compare
erwanor
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR adds an
AssetMetadataByIdsRPC method to the shielded pool query RPC. It relates to #4162 but does not close it, because the method is not yet implemented.(I realized halfway through that this actually isn't useful to web until the method is implemented, which I don't feel confident doing, so feel free to just use this PR as a starting point from which to build out the rest of the feature. Or, you can just merge it and then build the implementation in a separate PR.)
Relevant changes are here and here. The rest of the PR is just codegen/etc.
Issue ticket number and link
#4162
Checklist before requesting a review
If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: