chore: 🪹 remove empty event.rs files
#4198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
added
the
C-chore
cratelyn
force-pushed
the
kate/remove-empty-event-files
branch
from
01369f4 to
d69e506
Compare
while looking around through files named `event.rs`, per the description of #3504, i found that some of these files are empty. this commit removes these empty files.
cratelyn
force-pushed
the
kate/remove-empty-event-files
branch
from
d69e506 to
c0a01fd
Compare
conorsch
approved these changes
Apr 12, 2024
|
https://discord.com/channels/824484045370818580/935270886091673660/1228349853390868536 we talked about this in discord, and came to the decision that we should keep these files around. while they are empty now, they should soon be updated to contain things, as part of addressing #3504. the existence of these is a signpost for where to place events in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while looking around through files named
event.rs, per the description of #3504, i found that some of these files are empty. this commit removes these empty files.checklist before requesting a review
if this code contains consensus-breaking changes, i have added the "consensus-breaking" label. otherwise, i declare my belief that there are not consensus-breaking changes, for the following reason: