Fix routable asset ordering #4193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
added a commit
that referenced
this pull request
Apr 12, 2024
in #4193, @zbuc is working on some changes to the dex component. in the `penumbra-app` crate, we have a helpful utility to define a tracing subscriber that correctly interacts with `libtest`'s output capturing, and can be configured via `RUST_LOG` when running tests. this is a tremendously helpful aid in debugging issues during feature development, and is not specific to the `penumbra-app` crate. this commit hoists that test utility into a standalone library in `crates/test/`, so that other components like the dex can also create a guard to capture traces in tests. now we can share this, by doing this: ```rust #[tokio::test] async fn example_test_case() -> anyhow::Result<()> { // Install a test logger... let guard = set_tracing_subscriber(); // Test logic here... drop(guard); Ok(()) } ```
1 task
cratelyn
added a commit
that referenced
this pull request
Apr 12, 2024
in #4193, @zbuc is working on some changes to the dex component. in the `penumbra-app` crate, we have a helpful utility to define a tracing subscriber that correctly interacts with `libtest`'s output capturing, and can be configured via `RUST_LOG` when running tests. this is a tremendously helpful aid in debugging issues during feature development, and is not specific to the `penumbra-app` crate. this commit hoists that test utility into a standalone library in `crates/test/`, so that other components like the dex can also create a guard to capture traces in tests. now we can share this, by doing this: ```rust #[tokio::test] async fn example_test_case() -> anyhow::Result<()> { // Install a test logger... let guard = set_tracing_subscriber(); // Test logic here... drop(guard); Ok(()) } ``` #### checklist before requesting a review - [x] If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason: > only changes test code
zbuc
force-pushed
the
4189_be_liquidity_index
branch
from
df14206 to
5b54860
Compare
|
@erwanor we should be good to clean this up and work on a migration in a pairing session when you've got time |
1 task
zbuc
force-pushed
the
4189_be_liquidity_index
branch
from
5b54860 to
4f954f2
Compare
erwanor
approved these changes
Apr 17, 2024
zbuc
force-pushed
the
4189_be_liquidity_index
branch
from
93782db to
8af60e6
Compare
Signed-off-by: Chris Czub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Fixes the ordering of routable assets by liquidity as well as adds tests.
Issue ticket number and link
Closes #4189
Checklist before requesting a review