Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weā€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mock-consensus: šŸ«› two_validators adds two keys #4174

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

cratelyn
Copy link
Contributor

@cratelyn cratelyn commented Apr 8, 2024

fixes #3937.

this adds a two_validators method to the test node builder, so that tests may set up a test node that has two validator keys.

checklist before requesting a review

  • If this code contains consensus-breaking changes, I have added the "consensus-breaking" label. Otherwise, I declare my belief that there are not consensus-breaking changes, for the following reason:

    only adjusts test facilities

fixes #3937.

* #3937
* #3588

this adds a `two_validators` method to the test node builder, so that
tests may set up a test node that has two validator keys.
@cratelyn cratelyn self-assigned this Apr 8, 2024
@cratelyn cratelyn added this to the Sprint 4 milestone Apr 8, 2024
@cratelyn cratelyn added the A-mock-consensus Area: Relates to the mock consensus engine label Apr 8, 2024
Copy link
Member

@erwanor erwanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@erwanor erwanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops.

@cratelyn cratelyn merged commit 56c67ca into main Apr 9, 2024
7 checks passed
@cratelyn cratelyn deleted the kate/add-two-validators-mock-consensus branch April 9, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-mock-consensus Area: Relates to the mock consensus engine
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

tests: āž mock consensus can InitChain with two validators
2 participants