FMD Parameter Selection Breaking Changes #4137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
force-pushed
the
1087-fmd-parameter-selection
branch
from
ae9b006 to
50fc83a
Compare
hdevalence
reviewed
Mar 29, 2024
proto/penumbra/penumbra/core/component/shielded_pool/v1/shielded_pool.proto
Outdated
Show resolved
Hide resolved
hdevalence
reviewed
Mar 29, 2024
proto/penumbra/penumbra/core/component/shielded_pool/v1/shielded_pool.proto
Outdated
Show resolved
Hide resolved
hdevalence
reviewed
Mar 29, 2024
cratelyn
added
the
A-shielded-crypto
cronokirby
force-pushed
the
1087-fmd-parameter-selection
branch
from
8738ac9 to
ae1e92f
Compare
cronokirby
force-pushed
the
1087-fmd-parameter-selection
branch
from
ae1e92f to
d4913fa
Compare
cronokirby
force-pushed
the
1087-fmd-parameter-selection
branch
from
d4913fa to
f50757e
Compare
cronokirby
force-pushed
the
1087-fmd-parameter-selection
branch
from
beed4f0 to
bf45f7a
Compare
cronokirby
force-pushed
the
1087-fmd-parameter-selection
branch
from
bf45f7a to
447b75e
Compare
cronokirby
force-pushed
the
1087-fmd-parameter-selection
branch
2 times, most recently
from
5892f6e to
0e1425c
Compare
aubrika
added
the
friction
cronokirby
force-pushed
the
1087-fmd-parameter-selection
branch
from
8ce6712 to
e8d64c9
Compare
erwanor
added
consensus-breaking
BREAKING: This will break old clues and their detection
BREAKING: requires migration because we broke protobufs for shielded pool params.
This fixes the WASM build.
We broke the protobuf for the shielded pool params, by changing the structure of the FMD params, and this migrates that to the default for the new format.
cronokirby
force-pushed
the
1087-fmd-parameter-selection
branch
from
e8d64c9 to
3f933c1
Compare
…l.rs Co-authored-by: Erwan Or <[email protected]> Signed-off-by: Lúcás Meier <[email protected]>
Co-authored-by: Erwan Or <[email protected]> Signed-off-by: Lúcás Meier <[email protected]>
Co-authored-by: Erwan Or <[email protected]> Signed-off-by: Lúcás Meier <[email protected]>
…ne/penumbra into 1087-fmd-parameter-selection
erwanor
reviewed
May 21, 2024
| @@ -95,16 +112,20 @@ pub async fn migrate( | |||
| tracing::info!(?post_upgrade_root_hash, "post-upgrade root hash"); | |||
|
|
|||
| ( | |||
| start_time.elapsed().expect("start time is set"), | |||
| start_time.elapsed().expect("start time not set"), | |||
There was a problem hiding this comment.
@cronokirby fwiw, the convention is that you write why you expect the Result/Option to be Ok/Some
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part of #1087.
This restructures the way FMD parameters are handled so that we can choose different algorithms to update the parameters.
A migration has been written so that we move from the old format, where we had a hard-coded parameter, to a new format, where we have an algorithm as a chain parameter, and then update the current FMD parameter over time based on that algorithm. The protobufs are also structured so that we can easily add new algorithms over time, without making a breaking state change.
By default, the algorithm just chooses a constant parameter, so dynamic FMD params are not part of this PR.