ibc: use outbound_ics20_transfers_enabled chain parameter #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
reviewed
Mar 26, 2024
| @@ -116,7 +116,19 @@ impl AppActionHandler for Action { | |||
| .execute(state) | |||
| .await | |||
| } | |||
| Action::Ics20Withdrawal(action) => action.check_and_execute(state).await, | |||
| Action::Ics20Withdrawal(action) => { | |||
| // SAFETY: this is safe to check in parallel because IBC enablement cannot | |||
There was a problem hiding this comment.
I think you want to use check_historical then right? here it will get run sequentially before execution
avahowell
added
consensus-breaking
|
This is consensus-breaking (modification to validation rules), but it's not state-breaking because it doesn't require a migration to deploy (and doesn't modify the state schema) |
|
Discussed with @avahowell & @erwanor : we're going to merge this today, so it's included in v0.70.0 (#4087). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this uses the existing outbound_ics20_transfers_enabled to gate ics20 withdrawals