tests(app): 🎇 mock consensus delegates, and undelegates, to a validator #4044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
added
A-testing
This was referenced Mar 18, 2024
i'll tackle this tomorrow, delegating currently fails. i imagine i will need to flesh out more of the details in that transaction. |
cratelyn
commented
Mar 18, 2024
erwanor
reviewed
Mar 18, 2024
cratelyn
force-pushed
the
kate/mock-consensus-delegate-to-validator
branch
from
4628023 to
b88730d
Compare
cratelyn
changed the title
cratelyn
commented
Mar 19, 2024
There was a problem hiding this comment.
note for review: the diff on this looks very strange here, side-by-side view is probably best.
outlines two variables in `Delegate` into methods. these will be used by our staking test to facilitate the construction of delegation transactions.
see #3995. this test now delegates to, and then undelegates from, a validator. this does not yet include all of the assertions we would like to exercise in this test, but it does show that a validator correctly progresses through the active and defined states. in further work, we will fill out the other assertions described in #3995, particularly w.r.t. voting power and validator uptime.
cratelyn
force-pushed
the
kate/mock-consensus-delegate-to-validator
branch
from
b88730d to
0796223
Compare
erwanor
reviewed
Mar 20, 2024
| amount: self.delegation_amount, | ||
| asset_id: self.delegation_token().id(), | ||
| }); | ||
| let stake: Balance = self.unbonded_value().into(); |
There was a problem hiding this comment.
Totally subjective and lgtm, but I have come to appreciate struct literals because they make it immediately apparent what data we are constructing vs. using constructors that add a level of indirection.
There was a problem hiding this comment.
agree! this came out of a pairing session with henry, because want to use those same literals in the mock_consensus_staking test
There was a problem hiding this comment.
|
Race condition :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3995.
this test now delegates to, and then undelegates from, a validator.
this does not yet include all of the assertions we would like to
exercise in this test, but it does show that a validator correctly
progresses through the active and defined states.
in further work, we will fill out the other assertions described
in #3995, particularly w.r.t. voting power and validator uptime.