refactor(mock-consensus): 🔐 remove Keyring
#4039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
added
A-mock-consensus
cratelyn
force-pushed
the
kate/remove-mock-consensus-keyring
branch
from
18df408 to
1987525
Compare
Base automatically changed from
kate/mock-consensus-can-exercise-staking-component
to
main
March 18, 2024 15:26
previously, we added a `Keyring` newtype. this was a low-effort, thin newtype wrapper around a `BTreeMap<VerificationKey, SigningKey>`. this commit removes it. NB: this is based on #4001.
cratelyn
force-pushed
the
kate/remove-mock-consensus-keyring
branch
from
1987525 to
2ce17f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously, we added a
Keyringnewtype. this was a low-effort, thin newtype wrapper around aBTreeMap<VerificationKey, SigningKey>.this commit removes it.
NB: this is based on #4001.