Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(pcli): 🔇 make large tracing event trace-level #3989

Merged
merged 2 commits into from
Mar 11, 2024
Merged

tests(pcli): 🔇 make large tracing event trace-level #3989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f087c4
tests(pcli): 🔇 make large tracing event trace-level
cratelyn Mar 10, 2024
88fa01b
review: remove `undelegation_result`
cratelyn Mar 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions crates/bin/pcli/tests/network_integration.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,18 +323,13 @@ fn delegate_and_undelegate() {
.timeout(std::time::Duration::from_secs(TIMEOUT_COMMAND_SECONDS));
let undelegation_result = undelegate_cmd.assert().try_success();

tracing::debug!(?undelegation_result, "undelegation done - output");
tracing::debug!("undelegation done");
// If the undelegation command succeeded, we can exit this loop.
if undelegation_result.is_ok() {
break;
} else {
num_attempts += 1;
tracing::info!(
?undelegation_result,
num_attempts,
max_attempts,
"undelegation failed"
);
tracing::info!(num_attempts, max_attempts, "undelegation failed");
if num_attempts >= max_attempts {
panic!("Exceeded max attempts for fallible command");
}
Expand Down
Loading