app: 🤠 address warning

[cratelyn]

addresses this compiler warning:

warning: argument must be of the form: `expected = "error message"`
  --> crates/core/app/tests/spend.rs:97:1
   |
97 | #[cfg_attr(
   | ^
   |
   = note: errors in this attribute were erroneously allowed and will become a hard error in a future release

[erwanor]

    // 3. Simulate execution of the Spend action
    spend
        .check_stateless(transaction_context)
        .await
        .unwrap_err()
        .to_string()
        .contains("spend proof did not verify");

This should be wrapped in an assert! right?

[cratelyn]

    // 3. Simulate execution of the Spend action
    spend
        .check_stateless(transaction_context)
        .await
        .unwrap_err()
        .to_string()
        .contains("spend proof did not verify");

This should be wrapped in an assert! right?

i'm not sure. i didn't write this test, it was added in #3871. i just wanted to address the warning i'm seeing when building main

[erwanor]

Not a huge deal, but reading the last state of the proof test, I am not sure I understand why we expect this to panic? the attribute makes me think it might be a debug assert nested deep in arkworks? If so we should probably add a comment

[avahowell]

This is cursed, if you try to verify an invalid proof in debug mode, arkworks will panic with this error. So we expect this to panic in debug mode, in release mode it should error with an invalid spend proof. The way the test is written currently with contains() is a bug

[erwanor]

Ah yeah, np I'll ask @avahowell