dex: avoid chain halts in case of arb failures #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
had a problem deploying
to
smoke-test
GitHub Actions
Error
In #3893 we encountered a bug in arb search logic that caused a chain halt. While that bug shouldn't exist, it also shouldn't have stopped the entire chain. Rather, we should continue operating without performing arbitrage. This commit does not fix the bug in #3893, but it does mean that the effect of that bug is just to stop arb from occurring rather than halting the chain.
hdevalence
force-pushed
the
dodge-arb-halt
branch
from
7dbb2cd to
6db483a
Compare
hdevalence
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3893 we encountered a bug in arb search logic that caused a chain halt. While that bug shouldn't exist, it also shouldn't have stopped the entire chain. Rather, we should continue operating without performing arbitrage.
This commit does not fix the bug in #3893, but it does mean that the effect of that bug is just to stop arb from occurring rather than halting the chain.