staking: add a min_validator_stake first delegation requirement
#3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanor
force-pushed
the
erwan/3853_min_self_delegation
branch
from
fb64c8f to
a274d83
Compare
cratelyn
added
A-staking
cratelyn
approved these changes
Feb 24, 2024
Comment on lines
374
to
384
| let has_minimum_stake = unbonded_pool >= min_stake; | ||
|
|
||
| let new_state = match previous_state { | ||
| Defined if has_minimum_stake => Inactive, | ||
| Defined if !has_minimum_stake => Defined, | ||
| Active if has_minimum_stake => Active, | ||
| Active if !has_minimum_stake => Defined, | ||
| Inactive if has_minimum_stake => Inactive, | ||
| Inactive if !has_minimum_stake => Defined, | ||
| _ => unreachable!("the previous state was validated by the guard condition"), | ||
| }; |
There was a problem hiding this comment.
i love how this is laid out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3853
This PR:
Defined -> Inactivetransition from the delegate action executionmin_validator_staketry_precursor_transitionmethod to the validator state machine to safely drive transitions in/out of theDefinedstate