-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mock-consensus: ⭐ use transaction plan in tests #3866
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
added
C-enhancement
Category: an enhancement to the codebase
A-mock-consensus
Area: Relates to the mock consensus engine
labels
Feb 22, 2024
cratelyn
force-pushed
the
katie/mock-consensus-use-tx-plan
branch
from
February 23, 2024 02:59
56ca685
to
1171d94
Compare
i continued to push this along today.
for tomorrow: i'm currently seeing this error in my logs. noticeably, this doesn't propagate into an error. i'll investigate more tomorrow. update this happens on main prior to this change. i'm going to merge this, and track down the invalid binding signature in a distinct PR under the umbrella of #3788. |
This was referenced Feb 23, 2024
cratelyn
added a commit
that referenced
this pull request
Feb 23, 2024
debug logs are rather noisy as a default log level. use info for the default level, callers can opt in to higher verbosity with `RUST_LOG`. cherry-picked from #3866.
hdevalence
reviewed
Feb 24, 2024
cratelyn
force-pushed
the
katie/mock-consensus-use-tx-plan
branch
from
February 26, 2024 14:52
1171d94
to
81eea77
Compare
cratelyn
force-pushed
the
katie/mock-consensus-use-tx-plan
branch
from
February 26, 2024 15:28
81eea77
to
f553338
Compare
cratelyn
force-pushed
the
katie/mock-consensus-use-tx-plan
branch
from
February 26, 2024 15:29
f553338
to
5cf7162
Compare
cratelyn
changed the title
mock-consensus: ⭐ use transaction plan to add spends
mock-consensus: ⭐ use transaction plan in tests
Feb 26, 2024
cratelyn
added a commit
that referenced
this pull request
Feb 27, 2024
fixes #3788. this branch builds upon the work in #3857 and #3866, filling out the remaining holes in the transaction plan. this now performs a spend, using the mock consensus engine. --------- Co-authored-by: Henry de Valence <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-mock-consensus
Area: Relates to the mock consensus engine
C-enhancement
Category: an enhancement to the codebase
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App
tests #3588