Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies: 🧹 sort Cargo.toml dependencies #3835

Merged
merged 37 commits into from
Feb 15, 2024
Merged

dependencies: 🧹 sort Cargo.toml dependencies #3835

merged 37 commits into from
Feb 15, 2024

Conversation

cratelyn
Copy link
Contributor

cargo dependencies, sorted alphabetically. thanks to the magic of vim macros. 💖

sorted dependencies helps reduce the likelihood of merge conflicts when dependencies are added to a crate. long-term quality-of-life benefit 🙂

@cratelyn
view: sort cargo dependencies
5ed90d7
@cratelyn
crates/bench: sort cargo dependencies
9a701a8
@cratelyn
crates/proto: sort cargo dependencies
33f258c
@cratelyn
crates/wallet: sort cargo dependencies
334cc65
@cratelyn
crates/custody: sort cargo dependencies
d10451f
@cratelyn
tools/summonerd: sort cargo dependencies
1045ab8
@cratelyn
crates/bin/pcli: sort cargo dependencies
b7e6431
@cratelyn
crates/core/app: sort cargo dependencies
0ec18c6
@cratelyn
crates/core/num: sort cargo dependencies
6f4ef01
@cratelyn
crates/bin/pclientd: sort cargo dependencies
b62e1b1
@cratelyn
crates/cnidarium-component: sort cargo dependencies
bd58983
@cratelyn
crates/cnidarium: sort cargo dependencies
eb7fa44
@cratelyn
crates/core/asset: sort cargo dependencies
920d472
@cratelyn
crates/core/component/community-pool: sort cargo dependencies
a8b4b6d
@cratelyn
crates/core/component/compact-block: sort cargo dependencies
5bd2d48
@cratelyn
crates/core/component/dex: sort cargo dependencies
dd4fe6e
@cratelyn
crates/core/component/distributions: sort cargo dependencies
42c5612
@cratelyn
crates/core/component/fee: sort cargo dependencies
cfb421e
@cratelyn
crates/core/component/funding: sort cargo dependencies
94a1a9b
@cratelyn
crates/core/component/governance: sort cargo dependencies
e7c1ebc
@cratelyn
crates/core/component/ibc: sort cargo dependencies
404dcdc
@cratelyn
crates/core/component/sct: sort cargo dependencies
03d0685
@cratelyn
crates/core/component/shielded-pool: sort cargo dependencies
6c190c9
@cratelyn
crates/core/component/stake: sort cargo dependencies
9eb7592
@cratelyn
crates/core/keys: sort cargo dependencies
d3b4686
@cratelyn
crates/core/transaction: sort cargo dependencies
b5bdd92
@cratelyn
crates/core/txhash: sort cargo dependencies
8330dff
@cratelyn
crates/crypto/decaf377-fmd: sort cargo dependencies
232c81a
@cratelyn
crates/crypto/decaf377-ka: sort cargo dependencies
ecf8384
@cratelyn
crates/crypto/eddy: sort cargo dependencies
c6e3086
@cratelyn cratelyn added A-tooling Area: developer tooling for building Penumbra itself C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking. labels Feb 15, 2024
@cratelyn cratelyn added this to the Sprint 0 milestone Feb 15, 2024
@cratelyn cratelyn self-assigned this Feb 15, 2024
@cratelyn cratelyn marked this pull request as ready for review February 15, 2024 23:29
@conorsch conorsch self-requested a review February 15, 2024 23:34
conorsch
conorsch approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@conorsch conorsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time! LGTM, fine to merge when CI is green. One request: Let's make sure to squash-merge.

@cratelyn
Copy link
Contributor Author

Thanks for taking the time! LGTM, fine to merge when CI is green. One request: Let's make sure to squash-merge.

agreed. this would be a lot of commits to throw in main.

@cratelyn cratelyn merged commit fd46f26 into main Feb 15, 2024
6 checks passed
@cratelyn cratelyn deleted the katie/sort-some-cargo-dependencies branch February 15, 2024 23:46
This was referenced Feb 15, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conorsch conorsch conorsch approved these changes

Assignees

@cratelyn cratelyn

Labels
A-tooling Area: developer tooling for building Penumbra itself C-chore Codebase maintenance that doesn't fix bugs or add features, and isn't urgent or blocking.
Projects
Penumbra
Status: Done
Milestone
Sprint 0
Development

Successfully merging this pull request may close these issues.
2 participants
@cratelyn @conorsch