dex: 🏒 SwapClaimProof::verify is fallible
#3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just to be sure that we are turning all of these into field elements!
see #3777 for more information. this replaces the `Result::expect` statements with error variants that are propagated to the caller.
this helps clear away the assorted `foo.0.bar` sequences of accessors.
this subjectively cleans up the result expression(s) a bit, by tapping the proof result.
cratelyn
added
A-node
This was referenced Feb 15, 2024
cratelyn
added a commit
that referenced
this pull request
Feb 16, 2024
see #3777. this changes `DelegatorVoteProof::verify` so that it is fallible. errors will be propagated to the caller, rather than inducing a panic. * #3777 * #3829 as with #3829, i've applied some tlc to the code as i've addressed the core issue at hand (_panics_). noop code transformations are applied in distinct commits, to facilitate ease of review.
cratelyn
added a commit
that referenced
this pull request
Feb 16, 2024
see #3777. this changes `DelegatorVoteProof::verify` so that it is fallible. errors will be propagated to the caller, rather than inducing a panic. * #3777 * #3829 * #3833 as with #3829 and #3833, i've applied some tlc to the code as i've addressed the core issue at hand (_panics_). noop code transformations are applied in distinct commits, to facilitate ease of review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #3777 for more information. this replaces the
Result::expectstatements with error variants that are propagated to the caller.💟 some gardening is done along the way to make this code a little more visually consistent. refactoring changes are intentionally kept in separate commits, to facilitate ease of review.