penumbra: fix metrics by bumping helper crates #3801
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3745, we bumped the
metrics
crate to use0.22
.However, we missed a couple of its helper crates such as:
metrics-utils
metrics-exporter-prometheus
metrics-tracing-context
This is problematic, and apparently frequent cause of breakage, because ones need to use the same version of metrics across crates that register recorders in order for it to work.
One way to detect this mismatch is running this command on the workspace directory:
Later, we discovered that - unfortunately - the
[email protected]
crate had pinned of its dependency ([email protected]
) in order to enforce its MSRV policy (!), effectively locking us - and astria - out of completing our migration to22
.Fortunately, after some outreach a new release removing the pinned dependency was cut and we can now complete. This PR bumps the workspace to use appropriate crates. It should fix the metrics breakage.