Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

staking: add limit on number of validator funding streams #3768

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

erwanor
Copy link
Member

@erwanor erwanor commented Feb 7, 2024

Close #2195.

@cratelyn cratelyn added A-staking Area: Design and implementation of staking and delegation C-enhancement Category: an enhancement to the codebase labels Feb 8, 2024
@conorsch
Copy link
Contributor

Discussed the possibility of constifying this value with @erwanor, since it'd be a lot easier to reason about. We should still do that, but I'm not going to block merge on it: there are a bunch of related values like string length limits on the website fields that similarly should have a named const. Deferring that clean up for now, so we can focus on unblocking the upcoming 67 release.

@conorsch conorsch merged commit 0361a6d into main Feb 12, 2024
7 checks passed
@conorsch conorsch deleted the erwan/2195_limit_funding_streams branch February 12, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-staking Area: Design and implementation of staking and delegation C-enhancement Category: an enhancement to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit validator definitions to eight funding streams
3 participants