shielded-pool(component): simplify tracking of fmd parameters #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdevalence
requested changes
Feb 2, 2024
There was a problem hiding this comment.
I don't think we want to do this.
Long term the FMD parameters shouldn't be in the chain parameters anyways, similar to gas prices. They need to be dynamically adjusted based on transaction volume. The values in the AppParameters are just fixed starting parameters that should eventually be replaced by whatever parameters are needed to tune the auto-adjuster.
|
I see - tbh, I had not realized that it was V1 tagged but it is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #3713, a follow-up to #3617. Now that we have shielded pool parameters, we do not want to have a separate code path to update the FMD parameters without also updating the shielded pool params.