Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove display_confirm field #3719

Merged
merged 1 commit into from
Feb 1, 2024
Merged

remove display_confirm field #3719

merged 1 commit into from
Feb 1, 2024

Conversation

grod220
Copy link
Contributor

@grod220 grod220 commented Feb 1, 2024

Field in EphemeralAddressRequest is no longer valid

Reference: https://discord.com/channels/824484045370818580/1044394105498771506/1202648940265340938

@grod220
Copy link
Contributor Author

grod220 commented Feb 1, 2024

@Valentine1898 fyi

@conorsch
Copy link
Contributor

conorsch commented Feb 1, 2024

Protobuf lint is failing with

Run bufbuild/buf-breaking-action@v1
Error: Previously present field "2" with name "display_confirm" on message "EphemeralAddressRequest" was deleted.
Error: buf found 1 breaking changes.

because this is indeed a breaking change. We're aware and accept that, and in fact are trying conscientiously to frontload breaking changes prior to release of Testnet 65. As long as the other CI jobs pass, good to merge.

@conorsch conorsch self-requested a review February 1, 2024 16:35
@grod220 grod220 merged commit c7aefdc into main Feb 1, 2024
6 of 7 checks passed
@grod220 grod220 deleted the remove-display-confirm branch February 1, 2024 16:49
TalDerei pushed a commit that referenced this pull request Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants