asset: allow image URIs in asset metadata #3702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
hdevalence
force-pushed
the
uris-in-metadata
branch
from
f4af6a3 to
bd34bf2
Compare
This commit expands the `DenomMetadata` proto message to support the `images` field defined in the cosmos asset registry extensions. Per discussion on Telegram, the `logo_URIs` and `images` fields overlap in functionality, but `images` is more forward-compatible and extensible. It also has a proto-compatible name, so seems like a win to only use it. It also adds a test that we can parse metadata defined in the registry. To enable this, we need to configure pbjson-build to ignore unknown fields, which is the normal proto behavior.
hdevalence
force-pushed
the
uris-in-metadata
branch
from
bd34bf2 to
a9a230e
Compare
This was referenced Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit expands the
DenomMetadataproto message to support theimagesfield defined in the cosmos asset registry extensions.Per discussion on Telegram, the
logo_URIsandimagesfields overlap in functionality, butimagesis more forward-compatible and extensible. It also has a proto-compatible name, so seems like a win to only use it.It also adds a test that we can parse metadata defined in the registry. To enable this, we need to configure pbjson-build to ignore unknown fields, which is the normal proto behavior.