Implement view service restarts in summonerd #3689
Closed
+101
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the database being stale as a source of truth as to a lousy view service
erwanor
reviewed
Jan 27, 2024
| /// Also this is sort of a stop-gap for a more robust view service where this method won't be | ||
| /// necessary, so one should exercise skepticism that this method even exists. | ||
| pub async fn abort(&self) { | ||
| self.worker_handle.abort(); |
There was a problem hiding this comment.
Random observation, but if you want some stronger guarantees about the timing of the join handle cancellation, you can immediately await the worker handle and that will make this method return when those resources are actually released. It can be useful for testing.
|
closing in favor of view-internal logic / health checks |
|
Refs #3732. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the database being stale as a source of truth as to a lousy view service