ci: improve smoke test logging #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conorsch
approved these changes
Jan 24, 2024
Merged
conorsch
pushed a commit
that referenced
this pull request
Jan 24, 2024
There were a few problems with the changes in #3656. First, the YAML workflow file was poorly indented, which caused the job not to be evaluated, so we got a false green. Beyond that, the wrapper script needed handling for an undefined var, and a tweak to the backgrounding/logging changes. All are updated, and this change passes locally.
conorsch
pushed a commit
that referenced
this pull request
Jan 24, 2024
There were a few problems with the changes in #3656. First, the YAML workflow file was poorly indented, which caused the job not to be evaluated, so we got a false green. Beyond that, the wrapper script needed handling for an undefined var, and a tweak to the backgrounding/logging changes. All are updated, and this change passes locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR change the smoke test workflow to independently capture and display logs produced by
cometbft,pd, and thepcli/pclientdintegration tests. This makes it easy to visualize and isolate the source of a smoke test failure.It also sets a baseline of
infolevel debugging for tracing statements, anddebuglevel fornetwork_integrationtests.Finally, it offers the opportunity for users to run the integration tests with maximum logging level by detecting if debug mode is enabled for this action run (see screenshot).