-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threshold Custody: Implement Distributed Key Generation Protocol #3464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
force-pushed
the
threshold-custody-dkg
branch
from
December 5, 2023 05:14
3c572cc
to
41a30d1
Compare
cronokirby
force-pushed
the
threshold-custody-dkg
branch
from
December 5, 2023 05:16
41a30d1
to
f507f5e
Compare
One thing I think I forgot was to add a check in round2 that all the VKs are distinct and not equal to your own. |
cronokirby
force-pushed
the
threshold-custody-dkg
branch
from
December 5, 2023 18:54
f507f5e
to
033938b
Compare
redshiftzero
reviewed
Dec 5, 2023
proto/penumbra/penumbra/custody/threshold/v1alpha1/threshold.proto
Outdated
Show resolved
Hide resolved
proto/penumbra/penumbra/custody/threshold/v1alpha1/threshold.proto
Outdated
Show resolved
Hide resolved
cronokirby
force-pushed
the
threshold-custody-dkg
branch
from
December 6, 2023 19:38
033938b
to
c6a4723
Compare
cronokirby
force-pushed
the
threshold-custody-dkg
branch
from
December 6, 2023 19:39
d5a6035
to
79582c5
Compare
Co-authored-by: redshiftzero <[email protected]> Signed-off-by: Lúcás Meier <[email protected]>
Needed for the output of the DKG protocol, which will have these various bits separately.
We'll need this in short order
This allows initializing threshold custody with a dkg. This means the functionality we need for threshold custody is complete, modulo polish.
cronokirby
force-pushed
the
threshold-custody-dkg
branch
from
December 7, 2023 17:46
79582c5
to
83c2279
Compare
redshiftzero
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3346.
Closes #3347.