Add threshold custody commands to pcli #3449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Error
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Error
cronokirby
force-pushed
the
3342-threshold-custody-backend
branch
from
e4e1784 to
fa0d488
Compare
cronokirby
force-pushed
the
threshold-custody-pcli
branch
from
39be315 to
b4de742
Compare
cronokirby
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
This allows us to easily restructure them.
This also makes implementing the serialization much easier.
Also adds a stub terminal impl, which we'll fill in a bit.
This makes the config file not look absolutely stupid
Now threshold signing works with dealing
cronokirby
force-pushed
the
threshold-custody-pcli
branch
from
b4de742 to
2be490a
Compare
cronokirby
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
Co-authored-by: redshiftzero <[email protected]> Signed-off-by: Lúcás Meier <[email protected]>
cronokirby
temporarily deployed
to
smoke-test
GitHub Actions
Inactive
hdevalence
reviewed
Dec 1, 2023
hdevalence
reviewed
Dec 1, 2023
cronokirby
had a problem deploying
to
smoke-test
GitHub Actions
Failure
|
Is the failure in https://github.com/penumbra-zone/penumbra/actions/runs/7065721967/job/19236295269?pr=3449 spurious? |
|
I don't know, it doesn't seem obviously triggered by a failing expectation, we can re-run the job and find out.
|
|
Well, seems like it worked out now. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3343.
Closes #3344.
Closes #3345.
Probably want to merge #3383 first, then switch this PR to be based on main, and review it.