Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pcli: update denom handling to accept string args to parse statefully #4803

Open
aubrika opened this issue Aug 12, 2024 · 0 comments
Open

pcli: update denom handling to accept string args to parse statefully #4803

aubrika opened this issue Aug 12, 2024 · 0 comments
Labels
A-client Area: Design and implementation for client functionality _P-V2 Priority: after mainnet

Comments

@aubrika
Copy link
Contributor

aubrika commented Aug 12, 2024

Original comment:

This doesn't fix problems with argument parsing, a lot of pcli arguments specify denoms and have the string parsing done inside clap, which has to be stateless. Full support will need to change this to take string args and then parse after the app is loaded and the registry can be pulled from the view database. But that can be future work

Originally posted by @hdevalence in #4801 (comment)

@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Aug 12, 2024
@aubrika aubrika added A-client Area: Design and implementation for client functionality _P-V2 Priority: after mainnet and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Aug 12, 2024
@aubrika aubrika added this to Penumbra Aug 12, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Aug 12, 2024
@aubrika aubrika added this to the Sprint 10 milestone Aug 12, 2024
@aubrika aubrika removed this from the Sprint 10 milestone Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-client Area: Design and implementation for client functionality _P-V2 Priority: after mainnet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant