Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pcli tx lp close/withdraw take multiple position IDs #4217

Closed
hdevalence opened this issue Apr 16, 2024 · 0 comments · Fixed by #4490
Closed

Make pcli tx lp close/withdraw take multiple position IDs #4217

hdevalence opened this issue Apr 16, 2024 · 0 comments · Fixed by #4490
Labels
A-client Area: Design and implementation for client functionality C-enhancement Category: an enhancement to the codebase good first issue A good issue for people without existing context on the project. help wanted Help on this issue is welcomed! _P-low Priority: low _P-V1 Priority: slated for V1 release

Comments

@hdevalence
Copy link
Member

hdevalence commented Apr 16, 2024 •
edited by erwanor
Loading

Is your feature request related to a problem? Please describe.

It would be slightly more ergonomic to be able to pass multiple position IDs at once to close and withdraw, closing or withdrawing in a single transaction.

Prospective contributors: feel free to hit @erwanor on discord, or here, if you'd like to take this on
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Apr 16, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Apr 16, 2024
@erwanor erwanor added A-client Area: Design and implementation for client functionality C-enhancement Category: an enhancement to the codebase help wanted Help on this issue is welcomed! good first issue A good issue for people without existing context on the project. and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Apr 16, 2024
@aubrika aubrika added _P-low Priority: low _P-V1 Priority: slated for V1 release labels Apr 17, 2024
@kerber0x kerber0x mentioned this issue May 28, 2024
Merged
1 task
erwanor pushed a commit that referenced this issue May 30, 2024
@kerber0x
pcli(tx): close/withdraw multiple LPs at once (#4490)
58b389b 
## Describe your changes

This PR makes the pcli tx lp close/withdraw to take multiple position
IDs.

## Issue ticket number and link

Closes #4217

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > Client change
@github-project-automation github-project-automation bot moved this from Backlog to Done in Penumbra May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-client Area: Design and implementation for client functionality C-enhancement Category: an enhancement to the codebase good first issue A good issue for people without existing context on the project. help wanted Help on this issue is welcomed! _P-low Priority: low _P-V1 Priority: slated for V1 release
Projects
Penumbra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: pcli tx lp close/withdraw to accept multiple position IDs kerber0x/penumbra
3 participants
@hdevalence @erwanor @aubrika