Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auction: define domain and proto types #4206

Closed
10 tasks done
Tracked by #4196
erwanor opened this issue Apr 15, 2024 · 2 comments
Closed
10 tasks done
Tracked by #4196

auction: define domain and proto types #4206

erwanor opened this issue Apr 15, 2024 · 2 comments
Assignees
@zbuc @erwanor @cratelyn
Labels
A-auction Area: Relates to the auction component _P-high High priority _P-V1 Priority: slated for V1 release protobuf-changes Makes changes to the protobuf definitions.
Milestone
Sprint 4

Comments

@erwanor
Copy link
Member

erwanor commented Apr 15, 2024 •
edited
Loading

Part of #4196, this ticket tracks completion of adding the following domain types and protobuf definitions to the auction component:

  • AuctionId
  • AuctionNft
  • DutchAuctionDescription
  • DutchAuctionState
  • DutchAuction
  • ActionDutchAuctionSchedule
  • ActionDutchAuctionEnd
  • ActionDutchAuctionWithdraw
  • ActionDutchAuctionWithdrawView
  • ActionDutchAuctionScheduleView
@erwanor erwanor mentioned this issue Apr 15, 2024
Open
50 tasks
@github-project-automation github-project-automation bot moved this to Backlog in Penumbra Apr 15, 2024
@github-actions github-actions bot added the needs-refinement unclear, incomplete, or stub issue that needs work label Apr 15, 2024
@erwanor erwanor moved this from Backlog to In progress in Penumbra Apr 15, 2024
@erwanor erwanor added this to the Sprint 4 milestone Apr 15, 2024
@erwanor erwanor added _P-V1 Priority: slated for V1 release _P-high High priority protobuf-changes Makes changes to the protobuf definitions. A-auction Area: Relates to the auction component and removed needs-refinement unclear, incomplete, or stub issue that needs work labels Apr 15, 2024
@erwanor
Copy link
Member Author

erwanor commented Apr 15, 2024

Current shape of things:

  • the action handlers should be defined under penumbra_auction::component::action_handler::dutch.
  • the main Dutch* data structures live in the crate root and are namespaced via a auction::dutch module.
  • the general data structures e.g. AuctionId and AuctionNft live in the crate root in an auction module

@erwanor erwanor mentioned this issue Apr 15, 2024
Merged
1 task
erwanor added a commit that referenced this issue Apr 15, 2024
@erwanor @hdevalence @cratelyn
auction: define main dutch auction messages (#4208)
2aa7094 
## Describe your changes

This PR adds the main domain types and protobuf definitions for dutch
auction support.

## Issue ticket number and link

Part of #4206 

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

> Component is not hooked to the app yet and this just adds
messages/types.

---------

Signed-off-by: Erwan Or <[email protected]>
Co-authored-by: Henry de Valence <[email protected]>
Co-authored-by: katelyn martin <[email protected]>
This was referenced Apr 15, 2024
Merged
Closed
@zbuc zbuc mentioned this issue Apr 15, 2024
Merged
1 task
erwanor added a commit that referenced this issue Apr 15, 2024
@erwanor
auction: define schedule action and AH validation scaffold (#4210)
333e8db 
## Describe your changes

Create the action definition module and adds the
`ActionDutchAuctionSchedule` domain + pb message.

## Issue ticket number and link

Part of #4206. 

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

> Internal and the auction component is not hooked to the rest of the
app yet
erwanor pushed a commit that referenced this issue Apr 15, 2024
@zbuc
auction: add ActionDutchAuctionWithdraw and action views (#4213)
ea0ecbe 
## Describe your changes

Adds the skeleton for the `Withdraw`-related Dutch auction proto and
domain types.

## Issue ticket number and link

#4206 

## Checklist before requesting a review

- [x] If this code contains consensus-breaking changes, I have added the
"consensus-breaking" label. Otherwise, I declare my belief that there
are not consensus-breaking changes, for the following reason:

  > isolated to auctions component and not hooked up to the app
@erwanor
Copy link
Member Author

erwanor commented Apr 15, 2024

This is done, we're circling back to the elementary data structures:

  • implementing auction description hashing
  • augmenting the auction nft with denom metadata

to make way for an action handler validation + execution push.

@erwanor erwanor closed this as completed Apr 15, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Penumbra Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zbuc zbuc

@erwanor erwanor

@cratelyn cratelyn

Labels
A-auction Area: Relates to the auction component _P-high High priority _P-V1 Priority: slated for V1 release protobuf-changes Makes changes to the protobuf definitions.
Projects
Penumbra
Archived in project
Milestone
Sprint 4
Development

No branches or pull requests
3 participants
@zbuc @erwanor @cratelyn